Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct post-verification identity state in post-hooks #3863

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Apr 5, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 78.01%. Comparing base (800f8f1) to head (0ca0913).
Report is 1 commits behind head on master.

Files Patch % Lines
selfservice/strategy/code/strategy_verification.go 20.00% 2 Missing and 2 partials ⚠️
selfservice/strategy/link/strategy_verification.go 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3863      +/-   ##
==========================================
- Coverage   78.04%   78.01%   -0.04%     
==========================================
  Files         360      360              
  Lines       25233    25233              
==========================================
- Hits        19694    19686       -8     
- Misses       4033     4040       +7     
- Partials     1506     1507       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 6e63d06 into master Apr 5, 2024
28 of 29 checks passed
@aeneasr aeneasr deleted the post-verificaiton-hook branch April 5, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant