Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always issue session last #3876

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Apr 16, 2024

In post persist hooks, the session issuance hook always needs to come last. This fixes the getHooks function to ensure this.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

In post persist hooks, the session issuance hook always needs
to come last. This fixes the getHooks function to ensure this.
@hperl hperl requested a review from alnr April 16, 2024 14:43
@hperl hperl self-assigned this Apr 16, 2024
@aeneasr
Copy link
Member

aeneasr commented Apr 16, 2024

Test?

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (660f330) to head (4480370).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3876   +/-   ##
=======================================
  Coverage   78.05%   78.06%           
=======================================
  Files         360      360           
  Lines       25205    25208    +3     
=======================================
+ Hits        19675    19678    +3     
  Misses       4027     4027           
  Partials     1503     1503           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alnr alnr merged commit e942507 into master Apr 17, 2024
31 checks passed
@alnr alnr deleted the hperl/fix-always-issue-session-last branch April 17, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants