Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include all credentials in the duplicate credential hint #3881

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Apr 17, 2024

Previously, we only returned one conflicting credential type in the duplicate credential error. Now, we include all conflicting credential types.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from alnr April 17, 2024 16:06
@hperl hperl self-assigned this Apr 17, 2024
@hperl hperl force-pushed the hperl/fix-available_credential_types branch 2 times, most recently from d36d172 to a987d5e Compare April 19, 2024 07:10
@aeneasr
Copy link
Member

aeneasr commented Apr 19, 2024

Looks like some tests are failing

@hperl hperl force-pushed the hperl/fix-available_credential_types branch 3 times, most recently from 4369382 to d32f5f4 Compare April 22, 2024 08:52
@hperl hperl force-pushed the hperl/fix-available_credential_types branch from d32f5f4 to 0f783f2 Compare April 22, 2024 09:45
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.03%. Comparing base (696cc1b) to head (0f783f2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3881      +/-   ##
==========================================
- Coverage   78.05%   78.03%   -0.03%     
==========================================
  Files         360      360              
  Lines       25241    25246       +5     
==========================================
- Hits        19703    19701       -2     
- Misses       4032     4037       +5     
- Partials     1506     1508       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit e06c241 into master Apr 22, 2024
29 checks passed
@aeneasr aeneasr deleted the hperl/fix-available_credential_types branch April 22, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants