Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: db index and duplicate credentials error #3896

Merged
merged 4 commits into from
Apr 26, 2024
Merged

fix: db index and duplicate credentials error #3896

merged 4 commits into from
Apr 26, 2024

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Apr 25, 2024

This fixes two minor bugs

  • uses an improved index for getting the credential identifier from the user handle
  • checks if the password hash is set before suggesting it as a credential identifier on duplicate credential errors

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing regarding migration

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 78.06%. Comparing base (c435727) to head (d335e71).
Report is 2 commits behind head on master.

Files Patch % Lines
identity/manager.go 77.77% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3896      +/-   ##
==========================================
+ Coverage   78.01%   78.06%   +0.04%     
==========================================
  Files         360      360              
  Lines       25257    25276      +19     
==========================================
+ Hits        19705    19732      +27     
+ Misses       4041     4034       -7     
+ Partials     1511     1510       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hperl hperl requested review from piotrmsc and aeneasr April 26, 2024 08:27
@hperl hperl merged commit 9f34a21 into master Apr 26, 2024
29 checks passed
@hperl hperl deleted the hperl/fix-stuff branch April 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants