Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make identity schema provider a proper service #3908

Merged
merged 3 commits into from
May 2, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented May 2, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

zepatrik
zepatrik previously approved these changes May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 78.03%. Comparing base (e5d3b0a) to head (a23eb7e).

Files Patch % Lines
schema/schema.go 81.81% 2 Missing and 2 partials ⚠️
driver/registry.go 0.00% 3 Missing ⚠️
driver/registry_default.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3908      +/-   ##
==========================================
- Coverage   78.05%   78.03%   -0.03%     
==========================================
  Files         360      362       +2     
  Lines       25276    25296      +20     
==========================================
+ Hits        19730    19739       +9     
- Misses       4035     4046      +11     
  Partials     1511     1511              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 5288bc7 into master May 2, 2024
28 of 29 checks passed
@aeneasr aeneasr deleted the fix-url-redirect branch May 2, 2024 17:03
@aeneasr aeneasr restored the fix-url-redirect branch May 5, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants