Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove flows from log messages #3913

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (b5a66e0) to head (2ebdbb0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3913      +/-   ##
==========================================
+ Coverage   78.21%   78.28%   +0.07%     
==========================================
  Files         365      365              
  Lines       25586    25647      +61     
==========================================
+ Hits        20013    20079      +66     
+ Misses       4043     4039       -4     
+ Partials     1530     1529       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aeneasr
aeneasr previously approved these changes May 7, 2024
@jonas-jonas jonas-jonas requested a review from aeneasr July 9, 2024 08:19
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge after we merge AX v2 as I want to avoid a lot of rebasing

@aeneasr aeneasr merged commit 310a405 into master Jul 18, 2024
27 checks passed
@aeneasr aeneasr deleted the jonas-jonas/removeFlowsFromLogs branch July 18, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants