fix(oidc): grace period for continuity container on oidc callbacks #3915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hperl
previously approved these changes
May 7, 2024
| if _, err := s.d.ContinuityManager().Continue(r.Context(), w, r, sessionName, continuity.WithPayload(&cntnr)); err != nil { | ||
| if _, err := s.d.ContinuityManager().Continue(r.Context(), w, r, sessionName, | ||
| continuity.WithPayload(&cntnr), | ||
| continuity.WithExpireInsteadOfDelete(time.Minute), |
There was a problem hiding this comment.
Are we sure 1 minute is enough?
There was a problem hiding this comment.
I think it should be enough, at least for the discussed use case
|
This was merged as part of another PR |
|
Or was it? |
|
It was not. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3915 +/- ##
==========================================
+ Coverage 78.02% 78.08% +0.05%
==========================================
Files 362 362
Lines 25296 25341 +45
==========================================
+ Hits 19737 19787 +50
+ Misses 4047 4038 -9
- Partials 1512 1516 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments