Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade nyaruka/phonenumbers to v1.3.6 #3940

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented May 30, 2024

Upgrade nyaruka/phonenumbers to v1.3.6, which fixes a failure to parse valid phone numbers, such as +16453331111.

Closes #3933

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.08%. Comparing base (a14927d) to head (05f5c02).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3940      +/-   ##
==========================================
- Coverage   78.12%   78.08%   -0.04%     
==========================================
  Files         362      362              
  Lines       25503    25342     -161     
==========================================
- Hits        19924    19789     -135     
+ Misses       4052     4038      -14     
+ Partials     1527     1515      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hperl hperl merged commit 050a4dc into master Jun 3, 2024
29 checks passed
@hperl hperl deleted the jonas-jonas/updatePhoneNumberValidation branch June 3, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsonschema outdated tel validation
2 participants