Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve courier logging #3943

Merged
merged 1 commit into from
Jun 3, 2024
Merged

chore: improve courier logging #3943

merged 1 commit into from
Jun 3, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jun 3, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 77.08333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 78.11%. Comparing base (83792ef) to head (ee8f02f).
Report is 3 commits behind head on master.

Files Patch % Lines
courier/smtp_channel.go 58.82% 6 Missing and 1 partial ⚠️
courier/courier_dispatcher.go 86.36% 3 Missing ⚠️
courier/http_channel.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3943      +/-   ##
==========================================
+ Coverage   78.04%   78.11%   +0.07%     
==========================================
  Files         362      362              
  Lines       25342    25324      -18     
==========================================
+ Hits        19777    19783       +6     
+ Misses       4048     4024      -24     
  Partials     1517     1517              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aeneasr aeneasr merged commit fbbac77 into master Jun 3, 2024
29 of 31 checks passed
@aeneasr aeneasr deleted the improve-smtp branch June 3, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants