Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): remove unsupported credential types in deleteIdentityCredential operation #3993

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.24%. Comparing base (b5a66e0) to head (bdfd1c8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3993   +/-   ##
=======================================
  Coverage   78.23%   78.24%           
=======================================
  Files         365      365           
  Lines       25586    25575   -11     
=======================================
- Hits        20018    20010    -8     
+ Misses       4039     4037    -2     
+ Partials     1529     1528    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

type DeletableCredentialsType string

const (
DeletableCredentialsTypeOIDC DeletableCredentialsType = "oidc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for the SDK due to the renaming - is it really needed, assuming that we'll allow removing all credentials type in the future?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's fair.

If we are going to allow the other credentials to be removed (which I am in favor of), I am fine with leaving as is.

If not, this would remove another point of friction here (and potential support requests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants