Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: password migration hook config #4001

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Jul 16, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl self-assigned this Jul 16, 2024
aeneasr
aeneasr previously approved these changes Jul 16, 2024
jonas-jonas
jonas-jonas previously approved these changes Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.32%. Comparing base (e0a4010) to head (022c594).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4001      +/-   ##
==========================================
- Coverage   78.34%   78.32%   -0.02%     
==========================================
  Files         369      369              
  Lines       25967    25970       +3     
==========================================
- Hits        20344    20342       -2     
- Misses       4076     4080       +4     
- Partials     1547     1548       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zepatrik
zepatrik previously approved these changes Jul 16, 2024
@hperl hperl dismissed stale reviews from zepatrik, jonas-jonas, and aeneasr via ef81416 July 16, 2024 12:43
@hperl hperl force-pushed the hperl/fix-pw-migration-hook-2 branch from ef81416 to 133cc52 Compare July 16, 2024 16:20
@hperl hperl force-pushed the hperl/fix-pw-migration-hook-2 branch from 133cc52 to 022c594 Compare July 16, 2024 16:29
@hperl hperl merged commit 50deedf into master Jul 17, 2024
29 checks passed
@hperl hperl deleted the hperl/fix-pw-migration-hook-2 branch July 17, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants