Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed panic when DSN="memory" is configured #574

Merged
merged 7 commits into from
Jul 15, 2020
Merged

fix: Fixed panic when DSN="memory" is configured #574

merged 7 commits into from
Jul 15, 2020

Commits on Jul 13, 2020

  1. fix: moving DSN=memory logic from registry.go to driver_default.go 

    Excuting the migration logic in registry.go cause a panic as the registry is not initalized at that point. Therefore we decided to move the handling to driver_default.go, after the registry has been initalized.
    @tricky42
    tricky42 committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    0a1d38f View commit details
    Browse the repository at this point in the history

  2. fix: adding memory flavor to CircleCI e2e tests

    @tricky42
    tricky42 committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    6d21bd8 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. fix: Fixing DSN="memory" shortcut handling 

    Changed SQLite string used for shortcut "memory" to "sqlite://:memory:?_fk=true"
Adjusted tests
Minor fix to Makefile: changed docker image name to include -sqlite in tag for target docker as Kratos is compiled with SQLite support.
Added test case "memory" to e2e tests
Adjusted run.sh to only call kratos migrate sql if test case != "memory
    @tricky42
    tricky42 committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    7c9acad View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/ory/kratos into fix-move-… 

    …dsnmemory-handling
    @tricky42
    tricky42 committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    e7ba2e1 View commit details
    Browse the repository at this point in the history

  3. fix: cleanup + fixed old test

    @tricky42
    tricky42 committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    7bc40e8 View commit details
    Browse the repository at this point in the history

  4. Simplified check 

    gosimple S1008
    @tricky42
    tricky42 committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    aa6c79e View commit details
    Browse the repository at this point in the history

  5. fix: unset env var

    @tricky42
    tricky42 committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    c7a4ced View commit details
    Browse the repository at this point in the history