-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conventional commits v2 #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This is ready for re-review. Please merge only after ory/ci#94. |
aeneasr
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here comes v2 of the new system to enforce conventional commit style on pull requests. Big thanks to @zepatrik for providing detailed feedback about what didn't work with v1, providing pointers to a better solution, and even going the extra mile and submitting a possible upstream fix! 🚀
V2 finally provides the right abstractions that Ory needs (I think):
One problem with all previous versions was that the set of allowed titles and scopes was stored redundantly in every repo (in
.github/semantic.yml
). This is hard to maintain, for example when adding a new default scope we have to update this file in every repo. This problem no longer exists in v2.Please pay extra attention to the set of default titles and scopes. I'm not sure what I have so far is the correct set that is used by all Ory repos. Thanks!
This is used by ory/ci#94.