Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conventional commits v2 #160

Merged
merged 12 commits into from
Jul 27, 2022
Merged

feat: conventional commits v2 #160

merged 12 commits into from
Jul 27, 2022

Conversation

kevgo
Copy link
Contributor

@kevgo kevgo commented Jul 19, 2022

Here comes v2 of the new system to enforce conventional commit style on pull requests. Big thanks to @zepatrik for providing detailed feedback about what didn't work with v1, providing pointers to a better solution, and even going the extra mile and submitting a possible upstream fix! 🚀

V2 finally provides the right abstractions that Ory needs (I think):

  • a centralized Ory-specific set of default titles and scopes
    • most repos can use those and don't need any custom config files at all
  • a generic workflow definition that can be pushed to all repos as often as we want without overriding customizations
  • ability for individual repos to override particular settings via a separate file
  • ability to add titles and scopes to the existing sets

One problem with all previous versions was that the set of allowed titles and scopes was stored redundantly in every repo (in .github/semantic.yml). This is hard to maintain, for example when adding a new default scope we have to update this file in every repo. This problem no longer exists in v2.

Please pay extra attention to the set of default titles and scopes. I'm not sure what I have so far is the correct set that is used by all Ory repos. Thanks!

This is used by ory/ci#94.

@kevgo kevgo changed the title Conventional Commits v2 feat: conventional commits v2 Jul 19, 2022
@kevgo kevgo mentioned this pull request Jul 19, 2022
@kevgo
Copy link
Contributor Author

kevgo commented Jul 22, 2022

This is ready for re-review. Please merge only after ory/ci#94.

@aeneasr aeneasr merged commit 32137ce into ory:master Jul 27, 2022
@kevgo kevgo deleted the kg-conventional-commits-v2 branch July 27, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants