Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation of oauth2_introspection authenticator not up to date #549

Closed
epandurski opened this issue Oct 6, 2020 · 2 comments · Fixed by #648
Closed

Documentation of oauth2_introspection authenticator not up to date #549

epandurski opened this issue Oct 6, 2020 · 2 comments · Fixed by #648
Labels
good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.

Comments

@epandurski
Copy link

https://www.ory.sh/oathkeeper/docs/pipeline/authn#oauth2_introspection

This page does not mention the audience/target_audience field or whether it is verified by the authenticator. By looking at the code it seems that there is a verification for it. The documentation is lacking this information.
@aeneasr
Copy link
Member

aeneasr commented Oct 6, 2020

Would you be open to add this info to the documentation? :)

@aeneasr aeneasr added the docs label Oct 6, 2020
@epandurski
Copy link
Author

Yes, but the problem is that my knowledge of Go is practically zero, and I could not reliably understand the code without first learning quite a lot.

@aeneasr aeneasr added good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one. labels Oct 6, 2020
@ArthurKnoep ArthurKnoep mentioned this issue Mar 1, 2021
Merged
5 tasks
aeneasr pushed a commit that referenced this issue Mar 2, 2021
@ArthurKnoep
doc: add missing documentation for oauth2_introspection (#648)
34cf38c 
Closes #549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add missing documentation for oauth2_introspection
2 participants
@epandurski @aeneasr