Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http method into session.MatchContext #625

Closed
luozhihua opened this issue Jan 3, 2021 · 1 comment
Closed

Add http method into session.MatchContext #625

luozhihua opened this issue Jan 3, 2021 · 1 comment

Comments

@luozhihua
Copy link

When using authorizer: keto_engine_acp_ory, we need to configure required_action, and for a restful style api, in most cases the method represents the meaning of action, so if put http methods in session.MatchContext , It will be more convenient to use keto_engine_acp_ory, remote and remote_json authorizer.

In fact, in oathkeeper access rules, methods are used as a condition of match, so it should be put into session.MatchContext

@aeneasr
Copy link
Member

aeneasr commented Jan 8, 2021

Yes, adding them to MatchContext makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants