Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove listx dependency #1021

Merged
merged 2 commits into from
Nov 2, 2022
Merged

chore: remove listx dependency #1021

merged 2 commits into from
Nov 2, 2022

Conversation

kevgo
Copy link
Contributor

@kevgo kevgo commented Sep 23, 2022

listx doesn't seem to be used anywhere in this repo. Looking at https://github.com/ory/x/blob/master/tools/listx/main.go, it seem replacable with find -f -name "*.go" -not -path "./vendor/". Given that there isn't a vendor folder anymore, this seems obsolete altogether.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@kevgo kevgo requested a review from aeneasr as a code owner September 23, 2022 17:47
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #1021 (7d47e4b) into master (f68646e) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 7d47e4b differs from pull request most recent head 7597eeb. Consider uploading reports for the commit 7597eeb to get more accurate results

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
- Coverage   78.06%   78.05%   -0.02%     
==========================================
  Files          83       83              
  Lines        3999     3992       -7     
==========================================
- Hits         3122     3116       -6     
+ Misses        598      597       -1     
  Partials      279      279              
Impacted Files Coverage Δ
internal/driver.go 50.00% <0.00%> (-27.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kevgo kevgo merged commit ab50e06 into ory:master Nov 2, 2022
@kevgo kevgo deleted the kg-remove-listx branch November 2, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant