Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rollback log format configuration #165

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

sawadashota
Copy link
Contributor

@sawadashota sawadashota commented Jun 18, 2020

Proposed changes

Rollback log format configuration to log.format from log.formatter if unintentional. (because I couldn't find this change at CHANGELOG.md)
Environment variable is not changed because it remains LOG_FORMAT.

ref #155

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

Further comments

Signed-off-by: sawadashota <xiootas@gmail.com>
@sawadashota
Copy link
Contributor Author

@aeneasr Could you review this PR?
If my proposal is rejected, I think LOG_FORMAT should be changed to LOG_FORMATTER.

@aeneasr
Copy link
Member

aeneasr commented Jun 22, 2020

Sorry, I forgot this. Yup looks good!

@aeneasr aeneasr merged commit 0680e4e into ory:master Jun 22, 2020
@sawadashota
Copy link
Contributor Author

Thank you!

@sawadashota sawadashota deleted the fix_log_format branch June 22, 2020 10:50
@aeneasr
Copy link
Member

aeneasr commented Jun 22, 2020

v0.0.132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants