Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Every '#'-reference links to test if it's unknown #604

Closed
Soulofdestiny opened this issue Mar 9, 2016 · 4 comments
Closed

Every '#'-reference links to test if it's unknown #604

Soulofdestiny opened this issue Mar 9, 2016 · 4 comments

Comments

@Soulofdestiny
Copy link
Contributor

So we have a implemented redirect for 'poo#' and 'bsc#' tags in comments that are linking to progress.opensuse.org and bugzilla, and also a t# for a link to a specific test.

I've tried to use 'gh#' for a github pull request, but this was also link to a test, which most likely doesn't exist.

I would suggest to disable links for unknown tags (and implement a 'gh#' for github ;))

screenshot from 2016-03-09 15-15-11
@Soulofdestiny
Copy link
Contributor Author

just came to my mind that you can refer to either to pull requests for tests and/or for backend... so maybe we should just look into "os-autoinst-distri-opensuse" for now...

Soulofdestiny added a commit to Soulofdestiny/openQA that referenced this issue Mar 9, 2016
@Soulofdestiny
Add tag 'gh#' to reference github pull-requests
2caf49a 
As mentioned in Issue os-autoinst#604,
for now it's only referencing pull requests to os-autoinst-distri-opensuse
Soulofdestiny added a commit to Soulofdestiny/openQA that referenced this issue Mar 9, 2016
@Soulofdestiny
Add tag 'gh#' to reference github pull-requests
a92014b 
As mentioned in Issue os-autoinst#604,
for now it's only referencing pull requests to os-autoinst-distri-opensuse
@Soulofdestiny Soulofdestiny mentioned this issue Mar 9, 2016
Closed
@coolo
Copy link
Contributor

coolo commented Mar 9, 2016

openQA is a generic project - having a link from gh# to opensuse tests without any config option or whatsoever is not going to sync in.

@Soulofdestiny
Copy link
Contributor Author

Then it's even easier, isn't it?

Soulofdestiny added a commit to Soulofdestiny/openQA that referenced this issue Mar 9, 2016
@Soulofdestiny
Add tags to reference github prs and issues
2381bdf 
As mentioned in Issue os-autoinst#604,
added ghi# and ghp# to use in comments for referencing
issues (ghi#) in the os-autoinst project and
pull-requests (ghp#) in os-autoinst-distri-opensuse
Soulofdestiny added a commit to Soulofdestiny/openQA that referenced this issue Mar 9, 2016
@Soulofdestiny
Add tags to reference github prs and issues
0cfdb01 
As mentioned in Issue os-autoinst#604,
added ghi# and ghp# to use in comments for referencing
issues (ghi#) in the os-autoinst project and
pull-requests (ghp#) in os-autoinst-distri-opensuse
@okurz
Copy link
Member

okurz commented Nov 4, 2016

#973 adds generic github bugref markers. Also, unknown tags are ignored. please close.

@coolo coolo closed this as completed Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coolo @okurz @Soulofdestiny