Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow group overview query by result #531

Merged
merged 6 commits into from
Feb 3, 2016

Conversation

okurz
Copy link
Member

@okurz okurz commented Feb 2, 2016

This allows e.g. to show only failed builds. Could be included like in http://lists.opensuse.org/opensuse-factory/2016-02/msg00018.html for "known defects"

  • WebAPI: Test: Provide advanced query parameters for filtering
  • Scheduler: Allow build filtering by result
  • WebAPI: Test: Simplify group search
  • WebAPI: Test: Simplify use of args
  • Delete obsolete references to 'fulldetail'
  • Fix api/v1/job_templates for empty groups/machines

okurz added 6 commits February 2, 2016 16:12
As observed with local database.
fulldetail was retired in 7451a08 but
obviously not completely pruned from code.

This deletes all remaining references to the unused 'fulldetail' parameter.
Also allows for easier extension afterwards.
Forward all query parameters to query_jobs to allow specifying additional
query parameters which are then properly shown on the overview.
@coolo
Copy link
Contributor

coolo commented Feb 3, 2016

I'm fine with providing the functionality, but I disagree it's a good idea to link it in public. chromium on lxde is not important (and as such lxde passes), but if you link only failed tests, you spread the impression everything works.

coolo added a commit that referenced this pull request Feb 3, 2016
Allow group overview query by result
@coolo coolo merged commit 4c4cd34 into os-autoinst:master Feb 3, 2016
@okurz okurz deleted the feature/advanced_query branch February 3, 2016 13:28
@okurz
Copy link
Member Author

okurz commented Feb 3, 2016

but I disagree it's a good idea to link it in public

That's fine. We can discuss certain cases where it makes sense, e.g. for a webscraping script or a page which clearly states "known failures"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants