Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Pandas 2.1.0 deprecations #255

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

MichaelTiemannOSC
Copy link
Contributor

Merged against latest os-climate/main. This merge magically deleted my previous Pull Request #242.

Merged against latest os-climate/main.

Signed-off-by: Michael Tiemann <72577720+MichaelTiemannOSC@users.noreply.github.com>
@MichaelTiemannOSC MichaelTiemannOSC marked this pull request as ready for review September 20, 2023 18:21
Incorporate--inexplicably--changes from main for security-audit.yaml.
Why on earth GitHub makes this so difficult is one of life's mysteries.

Signed-off-by: Michael Tiemann <72577720+MichaelTiemannOSC@users.noreply.github.com>
@MichaelTiemannOSC
Copy link
Contributor Author

A Git Commit Tragedy in Three Acts.

Act I: Wherein we pushed a commit that triggered a security warning due to a bogus CVE related to numexpr. Tragic.

Act II: Commited change to security-audit.yaml to ignore the specific CVE. After committing that change, re-ran the tests for this pull request, which continued to fail in the same way, despite supposedly changing the underlying security-audit parameters in the github workflow. Why did that commit not set up audit for success? Doubly tragic.

Act III: Merged those upstream changes back into this PR, dirtying up the commit history with a trifecta of essentially completely redundant commit points. And yet...instead of successfully running the audit code with for sure the new code, it skipped the audit entirely, instead only validating the DCO and washing its hands of all other checks. A tragic end to Act III.

@MichaelTiemannOSC MichaelTiemannOSC merged commit 8661e02 into os-climate:main Sep 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant