Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relevance detector #26

Closed
wants to merge 60 commits into from

Conversation

tanishq-ids
Copy link
Contributor

added cli command with poetry under src/packages.

@tanishq-ids tanishq-ids reopened this Jun 20, 2024
@ModeSevenIndustrialSolutions
Copy link
Contributor

Looks good, but we might need to fix DCO, etc. Let's wait for the checks to finish...

@ModeSevenIndustrialSolutions
Copy link
Contributor

mypy.....................................................................Failed

  • hook id: mypy
  • duration: 0.17s
  • exit code: 2

src/osc_transformer_based_extractor/fine_tune.py: error: Source file found twice under different module names: "fine_tune" and "src.osc_transformer_based_extractor.fine_tune"
src/osc_transformer_based_extractor/fine_tune.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
src/osc_transformer_based_extractor/fine_tune.py: note: Common resolutions include: a) adding __init__.py somewhere, b) using --explicit-package-bases or adjusting MYPYPATH
Found 1 error in 1 file (errors prevented further checking)

markdownlint.............................................................Failed

  • hook id: markdownlint
  • exit code: 1

src/osc_transformer_based_extractor/README.md:20:1 MD029/ol-prefix Ordered list item prefix [Expected: 1; Actual: 2; Style: 1/2/3]
src/osc_transformer_based_extractor/README.md:65:1 MD029/ol-prefix Ordered list item prefix [Expected: 2; Actual: 3; Style: 1/2/3]

pydocstyle...............................................................Failed

  • hook id: pydocstyle
  • exit code: 1

src/package/osc-transformer-based-extractor/osc_transformer_based_extractor/init.py:1 at module level:
D104: Missing docstring in public package
setup.py:1 at module level:
D100: Missing docstring in public module
src/package/osc-transformer-based-extractor/tests/init.py:1 at module level:
D104: Missing docstring in public package
src/osc_transformer_based_extractor/fine_tune.py:1 at module level:
D100: Missing docstring in public module
src/osc_transformer_based_extractor/fine_tune.py:56 in public class CustomDataset:
D101: Missing docstring in public class
src/osc_transformer_based_extractor/fine_tune.py:57 in public method __init__:
D107: Missing docstring in init
src/osc_transformer_based_extractor/fine_tune.py:64 in public method __len__:
D105: Missing docstring in magic method
src/osc_transformer_based_extractor/fine_tune.py:67 in public method __getitem__:
D105: Missing docstring in magic method
src/osc_transformer_based_extractor/fine_tune.py:86 in public function fine_tune_model:
D103: Missing docstring in public function
src/osc_transformer_based_extractor/inference.py:30 in public function check_question_context:
D103: Missing docstring in public function
src/package/osc-transformer-based-extractor/osc_transformer_based_extractor/main.py:77 in public function perform_inference:
D202: No blank lines allowed after function docstring (found 1)
src/pytests/tess.py:1 at module level:
D100: Missing docstring in public module
src/pytests/tess.py:9 in public class MockTrainer:
D101: Missing docstring in public class
src/pytests/tess.py:10 in public method train:
D102: Missing docstring in public method
src/pytests/tess.py:13 in public method evaluate:
D102: Missing docstring in public method
src/pytests/tess.py:18 in public function mock_trainer:
D103: Missing docstring in public function
src/pytests/tess.py:23 in public function test_check_csv_columns_valid:
D103: Missing docstring in public function
src/pytests/tess.py:35 in public function test_check_csv_columns_missing_columns:
D103: Missing docstring in public function
src/pytests/tess.py:45 in public function test_check_output_dir_valid:
D103: Missing docstring in public function
src/pytests/tess.py:56 in public function test_check_output_dir_invalid:
D103: Missing docstring in public function
src/pytests/tess.py:66 in public function test_fine_tune_model:
D103: Missing docstring in public function

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make an effort to resolve the mypy and markdownlint issues before merging this. I've update the PR with some updates to address some of the low-hanging fruit. Can you pull my updates down and we can compare notes afterwards? I've pinged you on Slack.

Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
tanishq-ids and others added 28 commits June 24, 2024 11:45
Signed-off-by: tanishq-ids <166009643+tanishq-ids@users.noreply.github.com>
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
@tanishq-ids tanishq-ids deleted the relevance_detector branch July 17, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants