-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relevance detector #26
Conversation
Looks good, but we might need to fix DCO, etc. Let's wait for the checks to finish... |
mypy.....................................................................Failed
src/osc_transformer_based_extractor/fine_tune.py: error: Source file found twice under different module names: "fine_tune" and "src.osc_transformer_based_extractor.fine_tune" markdownlint.............................................................Failed
src/osc_transformer_based_extractor/README.md:20:1 MD029/ol-prefix Ordered list item prefix [Expected: 1; Actual: 2; Style: 1/2/3] pydocstyle...............................................................Failed
src/package/osc-transformer-based-extractor/osc_transformer_based_extractor/init.py:1 at module level: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make an effort to resolve the mypy and markdownlint issues before merging this. I've update the PR with some updates to address some of the low-hanging fruit. Can you pull my updates down and we can compare notes afterwards? I've pinged you on Slack.
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
90f9df5
to
c211bdb
Compare
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
14bd069
to
244552f
Compare
…dataservices.com>
…ishq.more@investmentdataservices.com>
…mentdataservices.com>
…tmentdataservices.com>
…estmentdataservices.com>
…entdataservices.com>
…tdataservices.com>
…stmentdataservices.com>
…tdataservices.com>
Signed-off-by: tanishq-ids <166009643+tanishq-ids@users.noreply.github.com>
…nvestmentdataservices.com>
…mentdataservices.com>
…entdataservices.com>
Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
….more@investmentdataservices.com>
added cli command with poetry under src/packages.