-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RG-249] settings improvement #1407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1407 +/- ##
=========================================
+ Coverage 9.29% 10.37% +1.08%
=========================================
Files 265 267 +2
Lines 30290 30304 +14
Branches 17328 17328
=========================================
+ Hits 2814 3144 +330
+ Misses 26716 26344 -372
- Partials 760 816 +56 ☔ View full report in Codecov by Sentry. |
@ravic-rs , this needs your attention |
This was blocked since we have labeller issue in CI. It's been resolved now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivate of the pull request
Describe the technical details
Key changes is class
ArgumentsMap
. It replaces std::string and used for parsing arguments for gui settings.Every
TclArgs_get/get<setting>Options
doesn't have to parse argument string. It happens on other level.Which part of the code base require a change