Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RG-249] settings improvement #1407

Merged
merged 7 commits into from
Dec 13, 2023
Merged

Conversation

KochynVolodymyr
Copy link
Contributor

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

Key changes is class ArgumentsMap. It replaces std::string and used for parsing arguments for gui settings.

Every TclArgs_get/get<setting>Options doesn't have to parse argument string. It happens on other level.

Which part of the code base require a change

  • Library: foedagcore, utils
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (463c972) 9.29% compared to head (c5754d1) 10.37%.

Files Patch % Lines
src/Main/Tasks.cpp 80.15% 2 Missing and 23 partials ⚠️
src/Main/WidgetFactory.cpp 0.00% 4 Missing ⚠️
src/Main/Settings.cpp 84.61% 2 Missing ⚠️
src/Utils/ArgumentsMap.cpp 95.12% 1 Missing and 1 partial ⚠️
src/MainWindow/Session.cpp 0.00% 0 Missing and 1 partial ⚠️
src/Utils/ArgumentsMap.h 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##            main    #1407      +/-   ##
=========================================
+ Coverage   9.29%   10.37%   +1.08%     
=========================================
  Files        265      267       +2     
  Lines      30290    30304      +14     
  Branches   17328    17328              
=========================================
+ Hits        2814     3144     +330     
+ Misses     26716    26344     -372     
- Partials     760      816      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alain-rs
Copy link
Contributor

@ravic-rs , this needs your attention

@ravic-rs
Copy link
Contributor

@ravic-rs , this needs your attention

This was blocked since we have labeller issue in CI. It's been resolved now.

@ravic-rs ravic-rs merged commit c1952f9 into main Dec 13, 2023
@ravic-rs ravic-rs deleted the task/RG-249/settings-improvement branch December 13, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants