Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new core clock flow #1673

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Support new core clock flow #1673

merged 4 commits into from
Aug 19, 2024

Conversation

chungshien-chai
Copy link
Collaborator

@chungshien-chai chungshien-chai commented Aug 15, 2024

<Put hold on while waiting RIC API be updated - see https://rapidsilicon.atlassian.net/browse/VIRGO-384>

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Together with os-fpga/yosys_verific_rs#760 and os-fpga/Raptor#1923, this changes auto-determine the needed core-clock. All the clock input is treated as fast clock

Also initial support of bidirectional pin

Testing done:

  • Port all these 4 changes (3 os-fpga repo + RIC API update) into latest NS Raptor
  • Run test/batch, test/batch_gen2 and test/batch_gen3

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 75.26882% with 69 lines in your changes missing coverage. Please review.

Project coverage is 14.93%. Comparing base (05eb41d) to head (aec8481).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
src/Configuration/ModelConfig/ModelConfig_IO.cpp 74.11% 19 Missing and 47 partials ⚠️
src/Configuration/ModelConfig/ModelConfig.cpp 50.00% 0 Missing and 2 partials ⚠️
...onfiguration/ModelConfig/ModelConfig_IO_resource.h 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1673      +/-   ##
==========================================
+ Coverage   14.73%   14.93%   +0.20%     
==========================================
  Files         480      480              
  Lines       63742    63979     +237     
  Branches    26063    26315     +252     
==========================================
+ Hits         9390     9558     +168     
- Misses      53154    53171      +17     
- Partials     1198     1250      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chungshien-chai chungshien-chai marked this pull request as ready for review August 19, 2024 23:52
@alaindargelas alaindargelas merged commit d35f0f0 into main Aug 19, 2024
31 of 33 checks passed
@alaindargelas alaindargelas deleted the foedag-io-core-clk branch August 19, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants