Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E tests #111

Closed
5 tasks
baruchiro opened this issue Jun 11, 2023 · 4 comments · Fixed by #124
Closed
5 tasks

Add E2E tests #111

baruchiro opened this issue Jun 11, 2023 · 4 comments · Fixed by #124
Assignees
@rzarviv
Labels
help wanted Extra attention is needed tests

Comments

@baruchiro
Copy link
Collaborator

I want to add E2E tests for:

  • Package Report is visible in npmjs.com
  • Package Report is visible in PyPI.org
  • Test the Package Report (tooltip) itself by validating there are advisories loaded into the list.
  • Test the popup visibility
  • Test the popup changes that affect the overlay on the page
@baruchiro baruchiro added help wanted Extra attention is needed tests labels Jun 11, 2023
@baruchiro baruchiro mentioned this issue Jun 11, 2023
Closed
@rzarviv
Copy link
Contributor

rzarviv commented Jun 12, 2023

Can you please assign this to me?

@github-actions
Copy link

Hey! This task was taken over a few days ago, but nothing has happened since then. Maybe the current contributor can comment on this?

@rzarviv
Copy link
Contributor

rzarviv commented Jun 21, 2023

Hi @baruchiro, I think that case #4 (Test the popup visibility) cannot be tested using Playwright.
According to Playwright's documentation about testing chrome extensions and this issue, accessing the Popup is possible only using the extension's URL (chrome-extension://${extensionId}/popup/index.html).

@baruchiro
Copy link
Collaborator Author

@rzarviv It's OK, let's test it with the URL, why not?

rzarviv added a commit to rzarviv/overlay that referenced this issue Jun 22, 2023
@rzarviv
- added e2e tests as described in issue os-scar#111
26b59b4
@rzarviv rzarviv mentioned this issue Jun 22, 2023
Merged
baruchiro added a commit that referenced this issue Jun 25, 2023
@rzarviv @baruchiro
test: e2e tests for npmjs, pypi and popup (#124)
eab59ae 
Added e2e tests as described in issue #111 

close #111

---------

Co-authored-by: Baruch Odem (Rothkoff) <baruchiro@gmail.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzarviv rzarviv

Labels
help wanted Extra attention is needed tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: e2e tests for npmjs, pypi and popup rzarviv/overlay
2 participants
@baruchiro @rzarviv