fix: ignore pip install .whl file #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baruchiro
approved these changes
Jul 29, 2023
Comment on lines
-1986
to
-1990
| - range: |- | ||
| <code>pip install scipy-0.16.1-cp27-none-win_amd64.whl | ||
| </code> | ||
| type: pypi | ||
| name: scipy-0.16.1-cp27-none-win_amd64.whl |
There was a problem hiding this comment.
@OshriAsulin please review this change made by me.
Make sure all the removed results are indeed wrong results, and all the added are correct.
baruchiro
reviewed
Jul 30, 2023
src/content/registry/python.test.js
Outdated
| @@ -17,6 +17,7 @@ describe(parseCommand.name, () => { | |||
| 'install numpy‑1.9.2+mkl‑cp34‑none‑win_amd64.whl', | |||
| 'install MySQL_python==', // Although this is a valid package name, it's not a valid command | |||
| 'install -r requirements.txt', | |||
| 'pip install scipy-0.16.1-cp27-none-win_amd64.whl', | |||
There was a problem hiding this comment.
Suggested change
| 'pip install scipy-0.16.1-cp27-none-win_amd64.whl', | |
| 'install scipy-0.16.1-cp27-none-win_amd64.whl', |
Removed pip word from the command in line 20
baruchiro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue of #140
Close #119
I added a change for ignore commands that end with
.whl,and I also added an example to real-examples.yaml