-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore pip install .whl file #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge once you verify the new example results.
- range: |- | ||
<code>pip install scipy-0.16.1-cp27-none-win_amd64.whl | ||
</code> | ||
type: pypi | ||
name: scipy-0.16.1-cp27-none-win_amd64.whl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OshriAsulin please review this change made by me.
Make sure all the removed results are indeed wrong results, and all the added are correct.
src/content/registry/python.test.js
Outdated
@@ -17,6 +17,7 @@ describe(parseCommand.name, () => { | |||
'install numpy‑1.9.2+mkl‑cp34‑none‑win_amd64.whl', | |||
'install MySQL_python==', // Although this is a valid package name, it's not a valid command | |||
'install -r requirements.txt', | |||
'pip install scipy-0.16.1-cp27-none-win_amd64.whl', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'pip install scipy-0.16.1-cp27-none-win_amd64.whl', | |
'install scipy-0.16.1-cp27-none-win_amd64.whl', |
Removed pip word from the command in line 20
Continue of #140
Close #119
I added a change for ignore commands that end with
.whl
,and I also added an example to real-examples.yaml