Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay breaks the UI on npmjs.com #158

Closed
baruchiro opened this issue Dec 27, 2023 · 1 comment · Fixed by #160
Closed

Overlay breaks the UI on npmjs.com #158

baruchiro opened this issue Dec 27, 2023 · 1 comment · Fixed by #160
Assignees
@yoavsbg
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@baruchiro
Copy link
Collaborator

baruchiro commented Dec 27, 2023 •
edited
Loading

Edge on Windows Version 120.0.2210.91 (Official build) (64-bit)

image
@baruchiro baruchiro added bug Something isn't working good first issue Good for newcomers labels Dec 27, 2023
@yoavsbg
Copy link
Contributor

yoavsbg commented Feb 13, 2024

I can take this issue :)

yoavsbg added a commit to yoavsbg/overlay that referenced this issue Feb 15, 2024
@yoavsbg
fix: issue os-scar#158 Overlay breaks the UI on npmjs.com
2a2a345
@baruchiro baruchiro mentioned this issue Feb 15, 2024
Merged
baruchiro pushed a commit that referenced this issue Feb 15, 2024
@yoavsbg
fix: overlay breaks the ui on npmjs.com (#158) (#160)
b050730 
Fix #158

change the injected overlay to be after the div element that represent
the "nom install <package>
after the fix here is the screenshots:

**npmjs.com**
![Screen Shot 2024-02-15 at 13 12
27](https://github.com/os-scar/overlay/assets/6542413/ca069e2b-9c57-4183-ac6a-9ba2092e5754)

**pypi.org**
![Screen Shot 2024-02-15 at 13 12
41](https://github.com/os-scar/overlay/assets/6542413/282df1c3-5841-4cd0-ab4f-c9bee0477702)

**stackoverflow.com**
![Screen Shot 2024-02-15 at 13 13
13](https://github.com/os-scar/overlay/assets/6542413/eb4c384a-5097-417f-ad4a-d575990e6fb3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoavsbg yoavsbg

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: overlay breaks the ui on npmjs.com (#158) yoavsbg/overlay
2 participants
@yoavsbg @baruchiro