Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link of a scoped package not opened correctly #97

Closed
rzarviv opened this issue Jun 5, 2023 · 2 comments · Fixed by #98
Closed

Link of a scoped package not opened correctly #97

rzarviv opened this issue Jun 5, 2023 · 2 comments · Fixed by #98
Assignees
@rzarviv

Comments

@rzarviv
Copy link
Contributor

rzarviv commented Jun 5, 2023

Clicking on a OpenSSF scorecard (a.k.a deps-dev) link of a scoped npm package (for example: @angular/cli) leads o a "package not found" page.

Steps to reproduce:

  1. Visit StackOverflow and find a page that contains a code section with a scoped package (for example: this link)
  2. Open the extension and click on the "open link" icon in OpenSSF Scorecard section. A new tab should be opened stating that the package could not be found.

solution
The following background/advisory/deps-dev.js causes the problem:
image

replacing name with encodeURIComponent(name) should solve the problem.
@rzarviv rzarviv changed the title Link of a scoped package not Link of a scoped package not opened correctly Jun 5, 2023
@rzarviv
Copy link
Contributor Author

rzarviv commented Jun 5, 2023

Hi @baruchiro , can you please assign me to solve this issue?

@baruchiro
Copy link
Collaborator

@rzarviv Thanks man!

rzarviv added a commit to rzarviv/overlay that referenced this issue Jun 5, 2023
@rzarviv
fix: Link of a scoped package not opened correctly (issue os-scar#97)
7ae7c0c 
-  encoded the package name to ensure the link will open properly
@baruchiro baruchiro mentioned this issue Jun 5, 2023
Merged
rzarviv added a commit to rzarviv/overlay that referenced this issue Jun 5, 2023
@rzarviv
fix: Link of a scoped package not opened correctly (issue os-scar#97)
14f8e7a 
-  encoded the package name to ensure the link will open properly
rzarviv added a commit to rzarviv/overlay that referenced this issue Jun 6, 2023
@rzarviv
fix: Link of a scoped package not opened correctly (issue os-scar#97)
f616837 
-  encoded the package name to ensure the link will open properly
baruchiro pushed a commit that referenced this issue Jun 6, 2023
@rzarviv
fix: Link of a scoped package not opened correctly (issue #97) (#98)
8718327 
encoded the package name to ensure the link will open properly.

Close #97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzarviv rzarviv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Link of a scoped package not opened correctly (issue #97) rzarviv/overlay
2 participants
@baruchiro @rzarviv