Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Link of a scoped package not opened correctly (issue #97) #98

Merged
merged 5 commits into from
Jun 6, 2023
Merged

fix: Link of a scoped package not opened correctly (issue #97) #98

merged 5 commits into from
Jun 6, 2023

Conversation

rzarviv
Copy link
Contributor

@rzarviv rzarviv commented Jun 5, 2023 •
edited by baruchiro
Loading

encoded the package name to ensure the link will open properly.

Close #97

@rzarviv
fix: Link of a scoped package not opened correctly (issue os-scar#97)
7ae7c0c 
-  encoded the package name to ensure the link will open properly
@baruchiro baruchiro self-requested a review June 5, 2023 13:17
baruchiro
baruchiro approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to think of a way to test such things, but I can't think of any useful test.

Anyway, since you found this. did you check if there is no such problem in the other advisories?

@rzarviv
Copy link
Contributor Author

rzarviv commented Jun 5, 2023 •
edited
Loading

I'm trying to think of a way to test such things, but I can't think of any useful test.

Anyway, since you found this. did you check if there is no such problem in the other advisories?

I checked the other advisors and the problem occurred only with deps.dev.

@rzarviv
Copy link
Contributor Author

rzarviv commented Jun 5, 2023

Shall I marge my code into the main branch?

@baruchiro
Copy link
Collaborator

You should squash it, can you?

@rzarviv
Copy link
Contributor Author

rzarviv commented Jun 5, 2023

Sure

@rzarviv rzarviv force-pushed the fix-scoped-packages-deps.dev branch from 7ae7c0c to 14f8e7a Compare June 5, 2023 17:01
@rzarviv
fix: Link of a scoped package not opened correctly (issue os-scar#97)
f616837 
-  encoded the package name to ensure the link will open properly
@rzarviv rzarviv force-pushed the fix-scoped-packages-deps.dev branch from 14f8e7a to f616837 Compare June 6, 2023 13:01
@rzarviv rzarviv closed this Jun 6, 2023
@rzarviv rzarviv reopened this Jun 6, 2023
@baruchiro
Copy link
Collaborator

@rzarviv go ahead, I'm not merging anything, to let you finish this finally :-)

@rzarviv rzarviv closed this Jun 6, 2023
@rzarviv
Copy link
Contributor Author

rzarviv commented Jun 6, 2023

Somehow I'm not able to rebase my changes into the main branch... do I need to grant write permissions for this?

@rzarviv rzarviv reopened this Jun 6, 2023
@baruchiro
Copy link
Collaborator

@rzarviv I sent you a message in Discord

@baruchiro baruchiro merged commit 8718327 into os-scar:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baruchiro baruchiro baruchiro approved these changes

Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link of a scoped package not opened correctly
2 participants
@rzarviv @baruchiro