-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Link of a scoped package not opened correctly (issue #97) #98
fix: Link of a scoped package not opened correctly (issue #97) #98
Conversation
- encoded the package name to ensure the link will open properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to think of a way to test such things, but I can't think of any useful test.
Anyway, since you found this. did you check if there is no such problem in the other advisories?
I checked the other advisors and the problem occurred only with deps.dev. |
Shall I marge my code into the |
You should squash it, can you? |
Sure |
7ae7c0c
to
14f8e7a
Compare
- encoded the package name to ensure the link will open properly
14f8e7a
to
f616837
Compare
@rzarviv go ahead, I'm not merging anything, to let you finish this finally :-) |
…rviv/overlay into fix-scoped-packages-deps.dev
…rviv/overlay into fix-scoped-packages-deps.dev
Somehow I'm not able to rebase my changes into the main branch... do I need to grant write permissions for this? |
@rzarviv I sent you a message in Discord |
encoded the package name to ensure the link will open properly.
Close #97