chore: change finding result structure #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eOfPositions function in range in order to accommodate the change in the Object Signed-off-by: Itay Goldraich <116950155+itay-goldraich@users.noreply.github.com>
Signed-off-by: Itay Goldraich <116950155+itay-goldraich@users.noreply.github.com>
Signed-off-by: Itay Goldraich <116950155+itay-goldraich@users.noreply.github.com>
baruchiro
reviewed
Jun 15, 2023
Signed-off-by: Itay Goldraich <116950155+itay-goldraich@users.noreply.github.com>
…thub.com/itay-goldraich/overlay into Refactor_Change_finding_result_structure
Signed-off-by: Itay Goldraich <116950155+itay-goldraich@users.noreply.github.com>
baruchiro
reviewed
Jun 15, 2023
baruchiro
reviewed
Jun 15, 2023
Signed-off-by: Itay Goldraich <116950155+itay-goldraich@users.noreply.github.com>
itay-goldraich
commented
Jun 15, 2023
baruchiro
reviewed
Jun 18, 2023
baruchiro
reviewed
Jun 18, 2023
baruchiro
changed the title
added 2 commits
June 19, 2023 17:51
baruchiro
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the structure.
I've looked for every reference of words with an index as part of them (index), yet found only two references to endIndex, both were fixed.
Now I'm looking for any errors or bugs my change might have created.