-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add discord notification #108
Conversation
2a80feb
to
2561833
Compare
first iteration split file for testing added step added link in message updated message modified string update string
2561833
to
5181cf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I reviewed but I forgot to send my review 😐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm blocked from changing the code in this PR, so please apply the two changes I requested and I will merge this.
Thanks!
added code suggestion Co-authored-by: Baruch Odem (Rothkoff) <baruchiro@gmail.com>
Added a discord notification workflow. The file added was used for testing purposes, and if anyone else would want to test it. It may also be used to split up the notifying workflow from the other build and publish workflow, and I guess more platform notifications will be added overtime, but it is up to you. The notification content is: ![Screenshot 2023-06-12 at 16 52 05](https://github.com/os-scar/overlay/assets/62609377/1c2b4e94-232a-4eab-8ecb-6e8e49b54fab) **when creating the Discord webhook you can choose the name of the bot --------- Co-authored-by: Baruch Odem (Rothkoff) <baruchiro@gmail.com>
organize imports - changed "chrome" to "browser" in background-events.js - added "tabs" permission to firefox manifest - moved event handler of URL_CHANGED to `content-events.js` - added a new subscription method for url change in `content.js` - added a test for issue os-scar#107 - moved EVENT_URL_CHANGED's event handler to the already existing listener. - changed page locator in test. - used a MutationObserver to insert `overlay-package-report` after the repository element is rendered (there are cases that the repository selector cannot be found since it's not yet rendered). - fixed test lint e2e too - removed "highlight" and fixed test - removed `tabs` permission from manifest - added utility function that waits for element to be rendered - rewrote test ci: add discord notification (os-scar#108) Added a discord notification workflow. The file added was used for testing purposes, and if anyone else would want to test it. It may also be used to split up the notifying workflow from the other build and publish workflow, and I guess more platform notifications will be added overtime, but it is up to you. The notification content is: ![Screenshot 2023-06-12 at 16 52 05](https://github.com/os-scar/overlay/assets/62609377/1c2b4e94-232a-4eab-8ecb-6e8e49b54fab) **when creating the Discord webhook you can choose the name of the bot --------- Co-authored-by: Baruch Odem (Rothkoff) <baruchiro@gmail.com> fix real examples lint e2e too - removed "highlight" and fixed test ci: add discord notification (os-scar#108) Added a discord notification workflow. The file added was used for testing purposes, and if anyone else would want to test it. It may also be used to split up the notifying workflow from the other build and publish workflow, and I guess more platform notifications will be added overtime, but it is up to you. The notification content is: ![Screenshot 2023-06-12 at 16 52 05](https://github.com/os-scar/overlay/assets/62609377/1c2b4e94-232a-4eab-8ecb-6e8e49b54fab) **when creating the Discord webhook you can choose the name of the bot --------- Co-authored-by: Baruch Odem (Rothkoff) <baruchiro@gmail.com> fix real examples - fixed typo
Added a discord notification workflow.
The file added was used for testing purposes, and if anyone else would want to test it.
It may also be used to split up the notifying workflow from the other build and publish workflow, and I guess more platform notifications will be added overtime, but it is up to you.
The notification content is:
![Screenshot 2023-06-12 at 16 52 05](https://private-user-images.githubusercontent.com/62609377/245164581-1c2b4e94-232a-4eab-8ecb-6e8e49b54fab.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMzIyNjIsIm5iZiI6MTcyNjEzMTk2MiwicGF0aCI6Ii82MjYwOTM3Ny8yNDUxNjQ1ODEtMWMyYjRlOTQtMjMyYS00ZWFiLThlY2ItNmU4ZTQ5YjU0ZmFiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDA5MDYwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE0ODk5MGRmYjZkNmYyM2RjZGFjMjdmODQzYWZjYWEyYjZkYWJkOTFkOWViY2ZkNGYwNTMyY2YyN2JjNzg5MDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sUMGPUm1bDhYlnoCoIt5ZjxjxHeohLOU78RalCD2zMs)
**when creating the Discord webhook you can choose the name of the bot