Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support pip3 install command #117

Merged
merged 7 commits into from
Jun 19, 2023
Merged

fix: support pip3 install command #117

merged 7 commits into from
Jun 19, 2023

Conversation

hagarfisher
Copy link
Contributor

@hagarfisher hagarfisher commented Jun 16, 2023 •
edited by baruchiro
Loading

  • added tests
  • support pip3
  • added this example to real-examples.yaml

Close #106

baruchiro
baruchiro reviewed Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, but I will review it on Sunday

tests/real-examples/real-examples-results.yaml Show resolved Hide resolved
@baruchiro baruchiro mentioned this pull request Jun 18, 2023
Closed
baruchiro
baruchiro approved these changes Jun 18, 2023
View reviewed changes
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!!

ThumbsUpNiceGIF

@baruchiro baruchiro merged commit ae54219 into os-scar:master Jun 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baruchiro baruchiro baruchiro approved these changes

Assignees

@hagarfisher hagarfisher

Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support pip3 install command
2 participants
@hagarfisher @baruchiro