Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: good-first-issue discord message #127

Merged
merged 9 commits into from
Jun 25, 2023

Conversation

itay-goldraich
Copy link
Contributor

@itay-goldraich itay-goldraich commented Jun 22, 2023

Close #120
The code worked on my channel.
It is required that a secret be created for a discord webhook and be named"DISCORD_WEBHOOK"

Signed-off-by: Itay Goldraich <116950155+itay-goldraich@users.noreply.github.com>
Signed-off-by: Itay Goldraich <116950155+itay-goldraich@users.noreply.github.com>
Signed-off-by: Itay Goldraich <116950155+itay-goldraich@users.noreply.github.com>
Signed-off-by: Itay Goldraich <116950155+itay-goldraich@users.noreply.github.com>
Signed-off-by: Itay Goldraich <116950155+itay-goldraich@users.noreply.github.com>
@itay-goldraich
Copy link
Contributor Author

Image from my discord channel.

test

Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more complicated than I thought, well done!

See my comments.

.github/workflows/new_good_first_issue.yml Outdated Show resolved Hide resolved
.github/workflows/new_good_first_issue.yml Outdated Show resolved Hide resolved
baruchiro and others added 2 commits June 25, 2023 09:08
- moved to project management
- added label name check
- remove on issue created
@baruchiro baruchiro changed the title Send a message to Discord when new "good-first-issue" was added ci: good-first-issue discord message Jun 25, 2023
@baruchiro baruchiro merged commit 52c4cab into os-scar:master Jun 25, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send a message to Discord when new "good-first-issue" was added
2 participants