email: Account for possible Orphaned SMTP Accounts

osTicket · Nov 30, 2022 · 10af29a · 10af29a
1 parent eac9960
commit 10af29a
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/include/staff/settings-emails.inc.php b/include/staff/settings-emails.inc.php
@@ -149,14 +149,17 @@
                     <?php
                     $accounts = SmtpAccount::objects()->filter(['active' => 1]);
                     foreach ($accounts as $account) {
+                        if (!($email=$account->getEmail()))
+                            continue;
+
                         $id = $account->getId();
-                        $email = sprintf('%s &lt;%s&gt;',
-                                $account->email->getName(),
-                                $account->email->getEmail());
+                        $addr = sprintf('%s &lt;%s&gt;',
+                                $email->getName(),
+                                $email->getEmail());
                         ?>
                         <option value="<?php echo $id; ?>"<?php
                             echo ($config['default_smtp_id'] == $id) ? 'selected="selected"' : ''; ?>><?php
-                            echo $email; ?></option>
+                            echo $addr; ?></option>
                         <?php
                     }
                     ?>