-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root and boot filesystem types #407
Comments
achilleas-k
added a commit
to achilleas-k/bootc-image-builder
that referenced
this issue
Aug 13, 2024
Iterate over each Mountable in the partition table (each filesystem) and change the filesystem type to match the rootfs, with two exceptions: - /boot/efi is never changed - /boot is not changed when rootfs is btrfs Do this *after* the partition table with the customizations has been generated, so that all filesystems in the final partition table are properly set. This also fixes osbuild#407.
achilleas-k
added a commit
to achilleas-k/bootc-image-builder
that referenced
this issue
Aug 14, 2024
Iterate over each Mountable in the partition table (each filesystem) and change the filesystem type to match the rootfs, with two exceptions: - /boot/efi is never changed - /boot is not changed when rootfs is btrfs Do this *after* the partition table with the customizations has been generated, so that all filesystems in the final partition table are properly set. This also fixes osbuild#407.
achilleas-k
added a commit
to achilleas-k/bootc-image-builder
that referenced
this issue
Aug 14, 2024
Iterate over each Mountable in the partition table (each filesystem) and change the filesystem type to match the rootfs, with two exceptions: - /boot/efi is never changed - /boot is not changed when rootfs is btrfs Do this *after* the partition table with the customizations has been generated, so that all filesystems in the final partition table are properly set. This also fixes osbuild#407.
achilleas-k
added a commit
to achilleas-k/bootc-image-builder
that referenced
this issue
Aug 14, 2024
Iterate over each Mountable in the partition table (each filesystem) and change the filesystem type to match the rootfs, with two exceptions: - /boot/efi is never changed - /boot is not changed when rootfs is btrfs Do this *after* the partition table with the customizations has been generated, so that all filesystems in the final partition table are properly set. This also fixes osbuild#407.
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 15, 2024
Iterate over each Mountable in the partition table (each filesystem) and change the filesystem type to match the rootfs, with two exceptions: - /boot/efi is never changed - /boot is not changed when rootfs is btrfs Do this *after* the partition table with the customizations has been generated, so that all filesystems in the final partition table are properly set. This also fixes #407.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our base partition tables define root and boot to be
ext4
. When building a base image that defines root to bexfs
, we change the configuration during manifest creation for root, but/boot
remainsext4
. I feel it's a bit weird to have/boot
beext4
when/
isxfs
. I wonder if we should keep them in sync.The text was updated successfully, but these errors were encountered: