-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add container installer test #109
Conversation
f6126f3
to
3584bd6
Compare
00215c5
to
4a74bfc
Compare
The testing farm tests fail with "no space left on device" :/ |
4a74bfc
to
0ee4fe1
Compare
0ee4fe1
to
00ea1f1
Compare
It looks like |
00ea1f1
to
77b62d1
Compare
Thanks, that is a nice catch and a good point. I renamed the vars a bit to (hopefully) make it more clear. Ideas/comments welcome! |
77b62d1
to
5504efe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
5504efe
to
ea94c5d
Compare
ea94c5d
to
3300e36
Compare
It looks like the test is currently failing because of an anaconda error? [edit: I tried this multiple times now and the exact crash differs, I also saw [edit2: this is bug https://github.com/fedora-eln/eln/issues/177] |
Add a new integration test that checks that the container installer is working. The contaner installer just does an unattended install of a disk. The test will run qemu with the installer.iso and an empty disk. Once a reboot from the ISO is detected (via QMP) qemu exists and boots the test disk and checks that it boots and the test user can login.
When running tests locally it can be useful to have a full qemu gui. E.g. the install test is not putting anything on the serial port AFAICT. So the new environment `OSBUILD_TEST_QEMU_GUI=1` will bring up a graphical qemu during the tests. Use as e.g. ``` $ sudo OSBUILD_TEST_QEMU_GUI=1 pytest -s -vv -rs './test/test_build.py::test_iso_installs[iso]' ```
4b9c2e9
to
954f839
Compare
There is a regression in ELN that prevents the installer from working [0]. To prevent this and in general provide more stability move to pinned fedora-eln sources. [0] fedora-eln/eln#177
954f839
to
2a50b21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Splendid. LGTM!
Add a new integration test that checks that the container installer
is working. The contaner installer just does an unattended install
of a disk. The test will run qemu with the installer.iso and an
empty disk. Once a reboot from the ISO is detected (via QMP) qemu
exists and boots the test disk and checks that it boots and the
test user can login.