bib: add support for the new Disk customizations
#721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
use-new-disk-customizations
branch
from
7be1324
to
16dcb79
Compare
achilleas-k
reviewed
Nov 22, 2024
bib/cmd/bootc-image-builder/image.go
Outdated
Comment on lines
207
to
208
| // XXX: remove once https://github.com/osbuild/images/pull/1054 is | ||
| // merged, then validation is part of GetPartitioning |
test/test_build.py
Outdated
| @@ -38,6 +38,7 @@ class ImageBuildResult(NamedTuple): | |||
| img_arch: str | |||
| container_ref: str | |||
| rootfs: str | |||
| partition_mode: str | |||
There was a problem hiding this comment.
This confused me a bit because it made me think of the disk.PartitioningMode that we have for the older partitioning customizations. This is only meant for tests and not user facing, so it's not really that important, but it might be confusing for test writing and reading.
I suggest we rename it to something else, something that implies it's a keyword for a particular test partitioning configuration (which is what it is, right?). Partitioning config maybe?
There was a problem hiding this comment.
Yeah, excellent feedback, I went with disk_config for now but partion_config or disk_customization would of course also be an option
mvo5
force-pushed
the
use-new-disk-customizations
branch
from
16dcb79
to
cbf73df
Compare
This commit makes use of the excellent work in osbuild/images#1041 and wires up support to generate LVM and btrfs volumes via the new disk customizations. It also add tests.
mvo5
force-pushed
the
use-new-disk-customizations
branch
from
cbf73df
to
b1af681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[It is draft right now because it has quite a few rough edges in the code but mostly because the LVM case is not working right now and it's unclear why, but pushing it will help with exposure/feedback, there are also some issues in "images" that are uncovered here that should be fixed there (like minsize seems to be not working for strings)]
This PR adds support for the new
Diskcustomizations from osbuild/images#1041 into bib.