test: Add test to check hostname length (HMS-5185) #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/jira-epic HMS-5164 |
schutzbot
changed the title
|
Also updated the validator a tiny bit to reflect the "up to 64 lower-case characters" part. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2681 +/- ##
=======================================
Coverage 85.23% 85.23%
=======================================
Files 175 175
Lines 20255 20253 -2
Branches 1976 1976
=======================================
- Hits 17264 17263 -1
+ Misses 2969 2968 -1
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
regexowl
force-pushed
the
check-hostname-length
branch
from
991ac64 to
1592f94
Compare
mgold1234
reviewed
Dec 12, 2024
This adds a test to check the length of the hostname.
Validation error mentions only lowercase characters, this updates the regex accordingly.
regexowl
force-pushed
the
check-hostname-length
branch
from
1592f94 to
2d2c37c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test to check the length of the hostname.
JIRA: HMS-5185