Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bootc switch --mutate-in-place for the Anaconda Container Installer #380

Closed
supakeen opened this issue Jan 17, 2024 · 5 comments · Fixed by #413
Closed

Use bootc switch --mutate-in-place for the Anaconda Container Installer #380

supakeen opened this issue Jan 17, 2024 · 5 comments · Fixed by #413
Assignees

Comments

@supakeen
Copy link
Member

bootc switch is growing a new hidden option to change the origin in-place, we can use this in %post for the container installer to set the offline installer's origin to the right place: containers/bootc#264

@cgwalters
Copy link
Contributor

I looked into this and the main thing seems to be plumbing through all the layers of abstraction from:

  • bib
  • NewAnacondaContainerInstaller()
  • AnacondaInstallerISOTree::serialize()
  • osbuild.NewKickstartStageOptionsWithOSTreeContainer
  • osbuild.NewKickstartStage

all the way to the org.osbuild.kickstart python code in osbuild - which does not seem to support %post.

So I think it'd be a matter of:

  • adding post to that
  • changing osbuild.NewKickstartStageOptionsWithOSTreeContainer

@cgwalters
Copy link
Contributor

I guess though now I wonder whether it'd be worth trying to just add the kickstart option, given how prominent this is.

@cgwalters
Copy link
Contributor

I did pykickstart/pykickstart#471 just to try to start something here.

@supakeen
Copy link
Member Author

Right now we have a shortcut in images to work with the relatively quickly changing landscape of this and write a kickstart file directly: https://github.com/osbuild/images/blob/main/pkg/manifest/anaconda_installer_iso_tree.go#L383

Though I much prefer having a kickstart option like you just linked because that's easier to move into the stage :)

@cgwalters
Copy link
Contributor

Thanks yes, I just discovered that 😄

I'm attempting to hack this up right now.

@cgwalters cgwalters assigned cgwalters and unassigned achilleas-k and supakeen Jan 30, 2024
cgwalters added a commit to cgwalters/osbuild-images that referenced this issue Jan 31, 2024
Basically anaconda/kickstart lacks support for `--target-image`
which we need when installing from a container image embedded
in the ISO.  Work around it with an injected `%post`.

Closes: osbuild#380
github-merge-queue bot pushed a commit that referenced this issue Feb 7, 2024
Basically anaconda/kickstart lacks support for `--target-image`
which we need when installing from a container image embedded
in the ISO.  Work around it with an injected `%post`.

Closes: #380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants