image: unify definition for Anaconda efiboot.img #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a small helper function for the efiboot.img partition. In all pipelines where we create an Anaconda installer, we use the same single partition table with the same size, so let's define it in one place. Note that the variable was incorrectly named `rootfsPartitionTable` in all cases, but it was in fact the pt for efiboot.img.
supakeen
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While preparing #388 I noticed that we define the efiboot.img partition table in every anaconda-based pipeline, so I decided to pull that out into a function.
Add a small helper function for the efiboot.img partition. In all pipelines where we create an Anaconda installer, we use the same single partition table with the same size, so let's define it in one place.
Note that the variable was incorrectly named
rootfsPartitionTablein all cases, but it was in fact the pt for efiboot.img.