-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osbuild: add org.osbuild.bootc.install-to-filesystem support #412
Merged
ondrejbudai
merged 3 commits into
osbuild:main
from
mvo5:osbuild/bootc-install-to-filesystem
Feb 13, 2024
Merged
osbuild: add org.osbuild.bootc.install-to-filesystem support #412
ondrejbudai
merged 3 commits into
osbuild:main
from
mvo5:osbuild/bootc-install-to-filesystem
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcl
reviewed
Jan 31, 2024
Clicked rebase because of a test cache change that landed in main: #432 |
achilleas-k
force-pushed
the
osbuild/bootc-install-to-filesystem
branch
from
February 9, 2024 15:45
ffe10cd
to
8480a9d
Compare
cgwalters
reviewed
Feb 12, 2024
achilleas-k
previously requested changes
Feb 12, 2024
It was pointed out that using: ``` makeOsbuildDevices("dev-/", "dev-/boot", "dev-/boot/efi") ``` is not obvious, so this commit changes it to ``` devices := makeOsbuildDevices("dev-for-/", "dev-for-/boot", "dev-for-/boot/efi") ``` which hopefully makes it a bit more clear.
This commit adds support for `org.osbuild.bootc.install-to-filesystem` from osbuild/osbuild#1547.
mvo5
force-pushed
the
osbuild/bootc-install-to-filesystem
branch
from
February 13, 2024 10:53
8480a9d
to
b7febee
Compare
ondrejbudai
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! :)
ondrejbudai
dismissed
achilleas-k’s stale review
February 13, 2024 14:41
Everything was resolved. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
org.osbuild.bootc.install-to-filesystem
from osbuild/osbuild#1547.