Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osbuild: add org.osbuild.bootc.install-to-filesystem support #412

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Jan 30, 2024

This PR adds support for org.osbuild.bootc.install-to-filesystem from osbuild/osbuild#1547.

@achilleas-k
Copy link
Member

Clicked rebase because of a test cache change that landed in main: #432

@achilleas-k achilleas-k force-pushed the osbuild/bootc-install-to-filesystem branch from ffe10cd to 8480a9d Compare February 9, 2024 15:45
pkg/osbuild/bootc_install_to_filesystem_stage.go Outdated Show resolved Hide resolved
pkg/osbuild/bootc_install_to_filesystem_stage_test.go Outdated Show resolved Hide resolved
It was pointed out that using:
```
makeOsbuildDevices("dev-/", "dev-/boot", "dev-/boot/efi")
```
is not obvious, so this commit changes it to
```
devices := makeOsbuildDevices("dev-for-/", "dev-for-/boot", "dev-for-/boot/efi")
```
which hopefully makes it a bit more clear.
This commit adds support for `org.osbuild.bootc.install-to-filesystem`
from osbuild/osbuild#1547.
@mvo5 mvo5 force-pushed the osbuild/bootc-install-to-filesystem branch from 8480a9d to b7febee Compare February 13, 2024 10:53
@mvo5 mvo5 marked this pull request as ready for review February 13, 2024 10:55
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@ondrejbudai ondrejbudai dismissed achilleas-k’s stale review February 13, 2024 14:41

Everything was resolved. :)

@ondrejbudai ondrejbudai added this pull request to the merge queue Feb 13, 2024
Merged via the queue into osbuild:main with commit 5e962aa Feb 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants