-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit: introduce pre-commit and fix linters #753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of a meta comment, would it make sense to introduce PRs with one linter at a time? That would probably make both the review and the commit history a bit easier to read :)
Not sure if this would create an unnecessary high number of PRs - but the straight forward ones and |
Yeah, maybe it's just ruff that tripped me up here :) |
5c75006
to
5d4e0e2
Compare
@mvo5 autopep8 seems to be ok, fixing lines that are too long but keeping others… please check |
5d4e0e2
to
0273063
Compare
0273063
to
de20d48
Compare
de20d48
to
fe29f54
Compare
fe29f54
to
27c8cb8
Compare
not sure if the settings of those pre-commit checks/linters are perfect but this commit would be a start to avoid having the round-trip with failing github tests, hopefully