Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: introduce pre-commit and fix linters #753

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

schuellerf
Copy link
Contributor

not sure if the settings of those pre-commit checks/linters are perfect but this commit would be a start to avoid having the round-trip with failing github tests, hopefully

test/scripts/boot-image Outdated Show resolved Hide resolved
@schuellerf schuellerf marked this pull request as draft June 18, 2024 13:00
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a meta comment, would it make sense to introduce PRs with one linter at a time? That would probably make both the review and the commit history a bit easier to read :)

@schuellerf
Copy link
Contributor Author

A bit of a meta comment, would it make sense to introduce PRs with one linter at a time? That would probably make both the review and the commit history a bit easier to read :)

Not sure if this would create an unnecessary high number of PRs - but the straight forward ones and ruff can be split, I guess🤔 😁

@mvo5
Copy link
Contributor

mvo5 commented Jun 18, 2024

A bit of a meta comment, would it make sense to introduce PRs with one linter at a time? That would probably make both the review and the commit history a bit easier to read :)

Not sure if this would create an unnecessary high number of PRs - but the straight forward ones and ruff can be split, I guess🤔 😁

Yeah, maybe it's just ruff that tripped me up here :)

@schuellerf
Copy link
Contributor Author

@mvo5 autopep8 seems to be ok, fixing lines that are too long but keeping others… please check

@schuellerf schuellerf added this pull request to the merge queue Jul 15, 2024
Merged via the queue into osbuild:main with commit 6320416 Jul 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants