Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add otk-make-fstab-stage helper #787

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Jul 8, 2024

This helper is similar to the otk-make-partition-stages but for
the fstab generation. It consumes the variables generated by
otk-gen-partition-table and produces a fragment to generate
the org.osbuild.fstab stage.

The expected usage is something like:

otk.define:
 filesystem:
   otk.external.gen_partition_table:
     modifications: ${modifications.filesystem}
     properties: ...
     partitions: ...

stages:
 ...
 otk.external.make_fstab_stage:
   internal: ${filesystem.internal}

Build on top of #732 only the last commit is relevant.

Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw this looks good :)

@mvo5 mvo5 force-pushed the cmd/otk-pt-fstab branch 2 times, most recently from 6c7419f to 986c213 Compare July 9, 2024 17:35
@mvo5 mvo5 requested a review from achilleas-k July 9, 2024 17:35
@mvo5 mvo5 marked this pull request as ready for review July 9, 2024 17:35
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Love how simple this turned out.

cmd/otk-make-fstab-stage/main.go Show resolved Hide resolved
@mvo5 mvo5 enabled auto-merge July 11, 2024 10:28
This helper is similar to the `otk-make-partition-stages` but for
the `fstab` generation. It consumes the variables generated by
`otk-gen-partition-table` and produces a fragment to generate
the `org.osbuild.fstab` stage.

The expected usage is something like:
```yaml
otk.define:
 filesystem:
   otk.external.gen_partition_table:
     modifications: ${modifications.filesystem}
     properties: ...
     partitions: ...

stages:
 ...
 otk.external.make_fstab_stage:
   internal: ${filesystem.internal}
```
@mvo5 mvo5 added this pull request to the merge queue Jul 29, 2024
Merged via the queue into osbuild:main with commit 730e912 Jul 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants