Test utility function for validating Partition Table sizes #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
force-pushed
the
test/validate-pt-sizes
branch
from
7f2a81d
to
5ee5791
Compare
croissanne
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a bug that occurs when converting a partition table to LVM with a root partition size that is larger than the original partition size (or larger than the partition table). @croissanne discovered it and we investigated it together yesterday. We both have ideas for how to fix it properly, but first I decided to write some tests to catch similar issues.
To keep things easier to follow and review, I decided to first introduce a utility function for validating partition table sizes. Currently this is a test utility function. If we discover that we need it outside of testing, we can move it to the
partition_table.gofile.