pkg/oscap: refactor & clean up #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some basic unit tests for the creation of the OpenSCAP remediation & tailoring configs.
The oscap tailoring and remediation configs were too tightly coupled with the osbuild stage implementations. These configs can be refactored further by making the `TailoringConfig` a pointer on the `RemediationConfig`, reversing the dependency of the configs. These changes should reduce the complexity of the OpenSCAP stage options and hopefully reduce some of the confusion too.
Add some new test cases to make sure that the remediation stage options are set correctly when tailoring options have been specified.
thozza
approved these changes
Aug 1, 2024
Thanks, I guess I was too close to the code and @thozza made a great suggestion and helped me zoom out a bit and untangle this... so big thanks to him for that! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oscap tailoring and remediation configs were too tightly coupled with the osbuild stage implementations. These configs can be refactored further by making the
TailoringConfiga pointer on theRemediationConfig, reversing the dependency of the configs.These changes should reduce the complexity of the OpenSCAP stage options and hopefully reduce some of the confusion too.
Thanks to @thozza for the suggestion