pathpolicy: move to generics and unexport pathTrie #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With generics support in go it seems like a good idea to move the `PathTrie` to a generic.
The `pathpolicy` packages is currently exporting the `PathTrie` data structure. It seems this is not really used outside of the package itself and more an implementation detail than a public API. So just unexport it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathpolicy: move
PathTrieto a genericWith generics support in go it seems like a good idea to move the
PathTrieto a generic.pathpolicy: unexport
PathTrieas it's an implementationdetail
The
pathpolicypackages is currently exporting thePathTriedata structure. It seems this is not really used outside of the
package itself and more an implementation detail than a public
API. So just unexport it.