-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplified-installer: add a test to mimic usb installation #3065
Conversation
Signed-off-by: Antonio Murdaca <runcom@linux.com>
Test passed in PR coreos/coreos-installer-dracut#18 |
perfect, we need to rebuild coreos-installer to include our updated code and land that into nightlies too before proceeding here |
Thats great! Thanks @runcom @henrywang |
I restarted the CI job, will check result later. |
Failed at this step, time out when provisioning edge vm with additional drive path. Will take a look of it. greenprint "💿 Install ostree image via installer(ISO) on UEFI VM" Error message: |
I tried it manually in my desktop, the vm installation hung there, and there is no output in the vm console. @runcom Maybe it is because the latest coreos-installer package does not have this PR coreos/coreos-installer-dracut#18? [root@yih-rhel91 osbuild-composer]# sudo virt-install --name=add-usb --disk path="${LIBVIRT_IMAGE_PATH}",format=qcow2 --disk path="${LIBVIRT_FAKE_USB_PATH}",format=qcow2 --ram 3072 --vcpus 2 --network network=integration,mac=34:49:22:B0:83:32 --os-type linux --os-variant ${OS_VARIANT} --cdrom /var/lib/libvirt/images/108028fa-0bdc-400f-9b30-fc75919fe727-simplified-installer.iso --boot uefi,loader_ro=yes,loader_type=pflash,nvram_template=/usr/share/edk2/ovmf/OVMF_VARS.fd,loader_secure=no --nographics --noautoconsole --wait=15 --noreboot Starting install... Domain is still running. Installation may be in progress. |
Yes we need to rebuild coreos-installer |
Thank you, do you have plan when to rebuild it? :) |
this week hopefully :) |
Will trigger test now, as https://bugzilla.redhat.com/show_bug.cgi?id=2144801 is ready for verify. |
coreos-installer bug https://bugzilla.redhat.com/show_bug.cgi?id=2144801 is tested and verified, a new coreos-installer package is now available in nightly repo. |
Turns out we've unfortunately broken USB installation with the new growfs service dealing with LVM in simplified installer - this test makes sure we test that by mimicking an USB being plugged in during installation (essentially having a new drive plugged into the VM). This test should just fail (get stuck) until we fix this in coreos-installer-dracut.
Signed-off-by: Antonio Murdaca runcom@linux.com