Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified-installer: add a test to mimic usb installation #3065

Closed
wants to merge 1 commit into from

Conversation

runcom
Copy link
Member

@runcom runcom commented Oct 12, 2022

Turns out we've unfortunately broken USB installation with the new growfs service dealing with LVM in simplified installer - this test makes sure we test that by mimicking an USB being plugged in during installation (essentially having a new drive plugged into the VM). This test should just fail (get stuck) until we fix this in coreos-installer-dracut.

Signed-off-by: Antonio Murdaca runcom@linux.com

Signed-off-by: Antonio Murdaca <runcom@linux.com>
@runcom runcom added the WIP+test Work in progress but run Gitlab CI. label Oct 12, 2022
@runcom
Copy link
Member Author

runcom commented Oct 12, 2022

cc @henrywang @7flying

@henrywang
Copy link
Member

Test passed in PR coreos/coreos-installer-dracut#18

@runcom
Copy link
Member Author

runcom commented Nov 17, 2022

Test passed in PR coreos/coreos-installer-dracut#18

perfect, we need to rebuild coreos-installer to include our updated code and land that into nightlies too before proceeding here

@sarmahaj
Copy link
Contributor

Test passed in PR coreos/coreos-installer-dracut#18

Thats great! Thanks @runcom @henrywang

@yih-redhat
Copy link
Contributor

I restarted the CI job, will check result later.

@yih-redhat
Copy link
Contributor

Failed at this step, time out when provisioning edge vm with additional drive path. Will take a look of it.

greenprint "💿 Install ostree image via installer(ISO) on UEFI VM"
sudo virt-install --name="${IMAGE_KEY}-usb"
--disk path="${LIBVIRT_IMAGE_PATH}",format=qcow2
--disk path="${LIBVIRT_FAKE_USB_PATH}",format=qcow2 \

Error message:
Creating domain... | 0 B 00:00
Domain is still running. Installation may be in progress.
Waiting 15 minutes for the installation to complete.
Installation has exceeded specified time limit. Exiting application.

@yih-redhat
Copy link
Contributor

I tried it manually in my desktop, the vm installation hung there, and there is no output in the vm console.

@runcom Maybe it is because the latest coreos-installer package does not have this PR coreos/coreos-installer-dracut#18?

[root@yih-rhel91 osbuild-composer]# sudo virt-install --name=add-usb --disk path="${LIBVIRT_IMAGE_PATH}",format=qcow2 --disk path="${LIBVIRT_FAKE_USB_PATH}",format=qcow2 --ram 3072 --vcpus 2 --network network=integration,mac=34:49:22:B0:83:32 --os-type linux --os-variant ${OS_VARIANT} --cdrom /var/lib/libvirt/images/108028fa-0bdc-400f-9b30-fc75919fe727-simplified-installer.iso --boot uefi,loader_ro=yes,loader_type=pflash,nvram_template=/usr/share/edk2/ovmf/OVMF_VARS.fd,loader_secure=no --nographics --noautoconsole --wait=15 --noreboot
WARNING --os-type is deprecated and does nothing. Please stop using it.

Starting install...
Creating domain... | 0 B 00:00:00

Domain is still running. Installation may be in progress.
Waiting 15 minutes for the installation to complete.
Installation has exceeded specified time limit. Exiting application.

@runcom
Copy link
Member Author

runcom commented Nov 21, 2022

Yes we need to rebuild coreos-installer

@yih-redhat
Copy link
Contributor

Yes we need to rebuild coreos-installer

Thank you, do you have plan when to rebuild it? :)

@runcom
Copy link
Member Author

runcom commented Nov 28, 2022

Thank you, do you have plan when to rebuild it? :)

this week hopefully :)

@yih-redhat
Copy link
Contributor

Will trigger test now, as https://bugzilla.redhat.com/show_bug.cgi?id=2144801 is ready for verify.

@yih-redhat
Copy link
Contributor

yih-redhat commented Dec 20, 2022

coreos-installer bug https://bugzilla.redhat.com/show_bug.cgi?id=2144801 is tested and verified, a new coreos-installer package is now available in nightly repo.
Will continue with this pr after new coreos-installer package can be used in CI env.

@yih-redhat
Copy link
Contributor

yih-redhat commented Jan 10, 2023

Hi @runcom , as this pr was created months ago and it only has test code change to test add usb, I have created a new pr to test add usb in simplified-installer, #3207 , CI is running now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP+test Work in progress but run Gitlab CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants