internal/distro/rhel9+8/edge: add sos package #3234

7flying · 2023-01-23T16:49:17Z

Adds the sos package to the edge commit package set so that users have built-in way to gather system logs and debug info.

This pull request includes:

adequate testing for the new functionality or fixed issue
adequate documentation informing people about the change such as
- submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

schutzbot

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 4b8b453 with the main merge-base 60e6107). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3646422042/artifacts/browse

schutzbot

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 7645ab7 with the main merge-base 2e3dd16). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3659056291/artifacts/browse

schutzbot

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 4c2de14 with the main merge-base 2e3dd16). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3660891305/artifacts/browse

schutzbot

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD b6f142a with the main merge-base fe78607). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3663875710/artifacts/browse

7flying · 2023-01-26T11:09:07Z

gen-manifests does not regerenate the manifests for 9.1, I have to wait until it is fixed

ondrejbudai · 2023-01-26T12:55:27Z

gen-manifests does not regerenate the manifests for 9.1, I have to wait until it is fixed

@7flying Can you expand on that? I'm not aware of anything being broken at the moment.

7flying · 2023-01-26T13:17:40Z

gen-manifests does not regerenate the manifests for 9.1, I have to wait until it is fixed

@7flying Can you expand on that? I'm not aware of anything being broken at the moment.

I've talked with @achilleas-k on slack (I think that I'm not allowed to paste the link), it's the last thread on osbuild-edge, there was some issue with the repository configuration

7flying · 2023-01-26T19:02:16Z

this PR depends on #3247 which fixes the rhel 9.1 manifest generation issue

7flying · 2023-01-27T08:08:29Z

Updated with the 9.1 manifests that were missing

schutzbot

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 07a4d6b with the main merge-base 6c503e4). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3670237622/artifacts/browse

schutzbot

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 1d2708f with the main merge-base a8b6fd4). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3671144033/artifacts/browse

7flying · 2023-01-30T09:05:07Z

schutzbot tells me that there have been manifest changes but regenerating them all doesn't seem to do anything (??, let's see...). This is a rebase.

schutzbot

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 339a562 with the main merge-base 081cc37). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3680633372/artifacts/browse

schutzbot

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 72daaad with the main merge-base 1667e6e). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3681357483/artifacts/browse

Adds the sos package to the edge commit package set so that users have built-in way to gather system logs and debug info. Signed-off-by: Irene Diez <idiez@redhat.com>

Similarly to the change made for rhel9, adding the sos package gives users a built-in way to gather system logs and debug info. Signed-off-by: Irene Diez <idiez@redhat.com>

Signed-off-by: Irene Diez <idiez@redhat.com>

schutzbot

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 302d521 with the main merge-base 70c61d4). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3682462160/artifacts/browse

achilleas-k

All good!

7flying changed the title ~~internal/distro/rhel9/edge: add sos package~~ [WIP] internal/distro/rhel9/edge: add sos package Jan 23, 2023

schutzbot reviewed Jan 23, 2023

View reviewed changes

7flying force-pushed the edge-sos branch from 4b8b453 to 7645ab7 Compare January 25, 2023 13:47

7flying changed the title ~~[WIP] internal/distro/rhel9/edge: add sos package~~ [WIP] internal/distro/rhel9+8/edge: add sos package Jan 25, 2023

7flying changed the title ~~[WIP] internal/distro/rhel9+8/edge: add sos package~~ internal/distro/rhel9+8/edge: add sos package Jan 25, 2023

schutzbot reviewed Jan 25, 2023

View reviewed changes

7flying force-pushed the edge-sos branch from 7bcd79e to 4c2de14 Compare January 25, 2023 17:29

schutzbot reviewed Jan 25, 2023

View reviewed changes

7flying force-pushed the edge-sos branch from 4c2de14 to b6f142a Compare January 26, 2023 08:46

schutzbot reviewed Jan 26, 2023

View reviewed changes

7flying force-pushed the edge-sos branch from b6f142a to 07a4d6b Compare January 27, 2023 08:07

schutzbot reviewed Jan 27, 2023

View reviewed changes

7flying force-pushed the edge-sos branch from 07a4d6b to 1d2708f Compare January 27, 2023 10:22

schutzbot reviewed Jan 27, 2023

View reviewed changes

7flying force-pushed the edge-sos branch from 1d2708f to 339a562 Compare January 30, 2023 09:03

schutzbot reviewed Jan 30, 2023

View reviewed changes

7flying force-pushed the edge-sos branch 2 times, most recently from f4c05ea to 72daaad Compare January 30, 2023 11:04

schutzbot reviewed Jan 30, 2023

View reviewed changes

7flying added 3 commits January 30, 2023 14:29

internal/distro/rhel9/edge: add sos package

f868d7e

Adds the sos package to the edge commit package set so that users have built-in way to gather system logs and debug info. Signed-off-by: Irene Diez <idiez@redhat.com>

internal/distro/rhel8/edge: add sos package for rhel8.6+ and CS8

5455aba

Similarly to the change made for rhel9, adding the sos package gives users a built-in way to gather system logs and debug info. Signed-off-by: Irene Diez <idiez@redhat.com>

test/data/manifests: regen for edge container + commit

302d521

Signed-off-by: Irene Diez <idiez@redhat.com>

7flying force-pushed the edge-sos branch from 72daaad to 302d521 Compare January 30, 2023 13:56

achilleas-k self-requested a review January 30, 2023 14:50

schutzbot reviewed Jan 30, 2023

View reviewed changes

achilleas-k approved these changes Jan 30, 2023

View reviewed changes

achilleas-k merged commit 1dfc82a into osbuild:main Jan 30, 2023

7flying deleted the edge-sos branch January 30, 2023 18:49

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

internal/distro/rhel9+8/edge: add sos package #3234

internal/distro/rhel9+8/edge: add sos package #3234

7flying commented Jan 23, 2023

schutzbot left a comment

schutzbot left a comment

schutzbot left a comment

schutzbot left a comment

7flying commented Jan 26, 2023

ondrejbudai commented Jan 26, 2023

7flying commented Jan 26, 2023

7flying commented Jan 26, 2023

7flying commented Jan 27, 2023 •

edited

Loading

schutzbot left a comment

schutzbot left a comment

7flying commented Jan 30, 2023 •

edited

Loading

schutzbot left a comment

schutzbot left a comment

schutzbot left a comment

achilleas-k left a comment

internal/distro/rhel9+8/edge: add sos package #3234

internal/distro/rhel9+8/edge: add sos package #3234

Conversation

7flying commented Jan 23, 2023

schutzbot left a comment

Choose a reason for hiding this comment

schutzbot left a comment

Choose a reason for hiding this comment

schutzbot left a comment

Choose a reason for hiding this comment

schutzbot left a comment

Choose a reason for hiding this comment

7flying commented Jan 26, 2023

ondrejbudai commented Jan 26, 2023

7flying commented Jan 26, 2023

7flying commented Jan 26, 2023

7flying commented Jan 27, 2023 • edited Loading

schutzbot left a comment

Choose a reason for hiding this comment

schutzbot left a comment

Choose a reason for hiding this comment

7flying commented Jan 30, 2023 • edited Loading

schutzbot left a comment

Choose a reason for hiding this comment

schutzbot left a comment

Choose a reason for hiding this comment

schutzbot left a comment

Choose a reason for hiding this comment

achilleas-k left a comment

Choose a reason for hiding this comment

7flying commented Jan 27, 2023 •

edited

Loading

7flying commented Jan 30, 2023 •

edited

Loading