Introduce jobtype variable in worker dashboard #3262
Conversation
croissanne
changed the title
croissanne
force-pushed
the
worker-dash-rework
branch
from
46caf81
to
ffe1d9d
Compare
|
Can you explain a bit more why is there a need to specify the target time statically please ? I think I kinda understand but a bit unsure. |
So per jobtype we have different targets of what consititutes "fast". We commit to 95% of depsolve jobs taking 32s or lower, and we commit to osbuild jobs taking less than 30 minutes. I haven't really found a way to change the jobtype and the target time at the same time, so I made a 2nd variable. The target time is needed to correctly calculate the error budget and slow request rates in the |
croissanne
force-pushed
the
worker-dash-rework
branch
from
ffe1d9d
to
8e2eee8
Compare
Awesome stuff. It looks a lot better and less cluttered like this. Pity about the jobtype... but I don't think it's a big deal. I mean this is mostly for us right? And I guess we'll know to switch the target duration for each job. would it make sense then to have. Having said that, would it make more sense to have the input selector be a single selector so you can only view one job at a time rather than a multi select? |
|
Discussed with Tom:
|
Ok so we don't actually add the arch label to the job_wait_duration metric.
|
This removes the rows of panels per job type, and uses the jobtype variable.
This aligns vertical dividers between panels across rows.
95th percentile duration is now a fixed colour, as it's tricky to get dynamic thresholds based on the job type. Budget remaining thresholds are now only green at infinity, turn yellow below 4 weeks, and turn red when budget consumption would only last 3 weeks (out of 4).
Display the wait duration of jobs per architecture.
croissanne
force-pushed
the
worker-dash-rework
branch
from
ee3bef0
to
ad1088f
Compare
|
Job wait duration per architecture is now available after #3289 |
The tradeoff is the 2nd target_duration variable. As it's tricky to have a variable with multiple values (so we could define the target duration per jobtype), you sort of need to know which target_duration to set for which jobtype (1792 for osbuild jobs, 32 for depsolve/resolve jobs).
https://grafana.stage.devshift.net/d/image-builder-worker-sanne/image-builder-worker-sanne?orgId=1