Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distro: remove duplicate version checks for fonts #3280

Merged
merged 1 commit into from
Mar 8, 2023
Merged

distro: remove duplicate version checks for fonts #3280

merged 1 commit into from
Mar 8, 2023

Conversation

supakeen
Copy link
Member

The new names of the packages are being added twice in two different checks, remove the redundant code.

schutzbot
schutzbot reviewed Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 0c87e0a with the main merge-base 6846f59). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3751751276/artifacts/browse

ondrejbudai
ondrejbudai previously approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ondrejbudai ondrejbudai dismissed their stale review February 15, 2023 11:39

The new code is sadly broken.

schutzbot
schutzbot reviewed Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD acf22ed with the main merge-base 96b42b5). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3800559290/artifacts/browse

ondrejbudai
ondrejbudai previously approved these changes Feb 23, 2023
View reviewed changes
@ondrejbudai ondrejbudai dismissed their stale review February 23, 2023 12:13

the manifests CI job fails

@ondrejbudai
Copy link
Member

The manifests CI job is failing, can you have a look, please?

schutzbot
schutzbot reviewed Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD acd11f3 with the main merge-base 0e4a5b3). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3886649563/artifacts/browse

schutzbot
schutzbot reviewed Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD b298952 with the main merge-base 0e4a5b3). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3887735782/artifacts/browse

@supakeen
distro: remove duplicate version checks for fonts
44db398 
The new names of the packages are being added twice in two different
checks, remove the redundant code.
schutzbot
schutzbot reviewed Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 44db398 with the main merge-base 0e4a5b3). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3888802651/artifacts/browse

ondrejbudai
ondrejbudai approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ondrejbudai
Copy link
Member

All Fedora tests passed, this is safe to be merged.

@ondrejbudai ondrejbudai merged commit 5f0d273 into osbuild:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schutzbot schutzbot schutzbot left review comments

@ondrejbudai ondrejbudai ondrejbudai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@supakeen @ondrejbudai @schutzbot